Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version transitions in CLI outputs #12739

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

idkgene
Copy link

@idkgene idkgene commented Dec 15, 2024

Changes

  • Updated the upgrade messaging to show both current and target versions
  • Added arrow symbol (→) to visually represent the version change

Before:

@astrojs/tailwind can be updated to v5.1.3

After:

@astrojs/tailwind can be updated v4.0.0 → v5.1.3

Testing

Updated existing test suite by modifying test assertions to verify new message format

Docs

Should be self-explanatory

Additional

Coming from withastro/roadmap#1069

- Updated the upgrade function to include the current version in the upgrade message format.
- Modified test assertions to reflect the new message format.

Background & Motivation:
The current output format lacks clarity in showing version changes. Adding a simple 'from → to' format improves visibility and developer experience when updating Astro packages.

Before:
@astrojs/tailwind can be updated to v5.1.3

After:
@astrojs/tailwind can be updated v4.0.0 → v5.1.3

This change:
- Makes the upgrade process "more transparent"
- Simplifies version change tracking
- Improves DX during updates

See withastro/roadmap#1069
Copy link

changeset-bot bot commented Dec 15, 2024

⚠️ No Changeset found

Latest commit: da9b3b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@idkgene
Copy link
Author

idkgene commented Dec 15, 2024

This is opinionated, I am open to any adjustments

@idkgene idkgene marked this pull request as draft December 15, 2024 03:44
- Remove 'to' particle from update messages
- Adjusted spacing in version comparison output
- Update tests to match the spacing

Before:
▲  astro can be updated to v1.0.0 → v2.0.0

After:
▲  astro can be updated  v1.0.0 → v2.0.0
@idkgene idkgene marked this pull request as ready for review December 15, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant